Jika/element-web
1
0
Fork 0
Code Issues Pull Requests Projects Wiki Activity

cleaning: Stop using deprecated callMembershipsForRoom (#31616)

Browse Source 
* cleaning: Stop using deprecated callMembershipsForRoom

* fix test

* review: Added quick doc
This commit is contained in:
Valere Fedronic
2026-01-05 14:47:10 +01:00
committed by GitHub
parent 5e6ee49509
commit 0c47ca2a45
3 changed files with 17 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
test/unit-tests/Notifier-test.ts
View File

@@ -19,7 +19,7 @@ import {
type AccountDataEvents,
} from "matrix-js-sdk/src/matrix";
import { waitFor } from "jest-matrix-react";
import { CallMembership, MatrixRTCSession } from "matrix-js-sdk/src/matrixrtc";
import { CallMembership, type MatrixRTCSession } from "matrix-js-sdk/src/matrixrtc";
import type BasePlatform from "../../src/BasePlatform";
import Notifier from "../../src/Notifier";
@@ -433,7 +433,7 @@ describe("Notifier", () => {
});
it("should not show toast when group call is already connected", () => {
const spyCallMemberships = jest.spyOn(MatrixRTCSession, "callMembershipsForRoom").mockReturnValue([
const members = [
new CallMembership(
mkEvent({
event: true,
@@ -450,14 +450,17 @@ describe("Notifier", () => {
device_id: "DEVICE",
},
),
]);
];
const roomSession = MatrixRTCSession.roomSessionForRoom(mockClient, testRoom);
const mockRtcSession = {
memberships: members,
slotDescription: { application: "m.call", id: "" },
} as unknown as MatrixRTCSession;
mockClient.matrixRTC.getRoomSession.mockReturnValue(mockRtcSession);
mockClient.matrixRTC.getRoomSession.mockReturnValue(roomSession);
emitCallNotificationEvent();
expect(ToastStore.sharedInstance().addOrReplaceToast).not.toHaveBeenCalled();
spyCallMemberships.mockRestore();
});
it("should not show toast when calling with a different event type to org.matrix.msc4075.rtc.notification", () => {

3
test/unit-tests/createRoom-test.ts
View File

@@ -17,7 +17,6 @@ import {
RoomVersionStability,
} from "matrix-js-sdk/src/matrix";
import { type CryptoApi } from "matrix-js-sdk/src/crypto-api";
import { MatrixRTCSession } from "matrix-js-sdk/src/matrixrtc";
import { act } from "jest-matrix-react";
import {
@@ -292,8 +291,6 @@ describe("createRoom", () => {
it("sets up Element video rooms correctly", async () => {
const createCallSpy = jest.spyOn(ElementCall, "create");
const callMembershipSpy = jest.spyOn(MatrixRTCSession, "callMembershipsForRoom");
callMembershipSpy.mockReturnValue([]);
await createRoom(client, { roomType: RoomType.UnstableCall });