From a183953ee898c7cfe2266e405d35235872bfecd0 Mon Sep 17 00:00:00 2001
From: 4lDO2 <4lDO2@protonmail.com>
Date: Sat, 13 Feb 2021 00:31:46 +0100
Subject: [PATCH] Motivate usage of the IST without SWAPGS involved.

---
 src/arch/x86_64/idt.rs | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/src/arch/x86_64/idt.rs b/src/arch/x86_64/idt.rs
index 407db03..06c7171 100644
--- a/src/arch/x86_64/idt.rs
+++ b/src/arch/x86_64/idt.rs
@@ -155,10 +155,11 @@ pub unsafe fn init_generic(is_bsp: bool, idt: &mut Idt) {
     IDTR.base = current_idt.as_ptr() as *const X86IdtEntry;
 
     let backup_ist = {
-        // A problem with SWAPGS, is that if a non-maskable interrupt were to occur in the middle
-        // of swapping, the CS would now point to the new kernel CS from the kernel-triggered
-        // interrupt, and no swap would occur. Thus, we give the NMI handler a separate stack. This
-        // is also true for Machine Check, and for Double Faults, but for other reasons.
+        // We give Non-Maskable Interrupts, Double Fault, and Machine Check exceptions separate
+        // stacks, since these (unless we are going to set up NMI watchdogs like Linux does) are
+        // considered the most fatal, especially Double Faults which are caused by errors __when
+        // accessing the system IDT__. If that goes wrong, then kernel memory may be partially
+        // corrupt, and we want a separate stack.
         //
         // Note that each CPU has its own "backup interrupt stack".
         let index = 1_u8;