Return empty stack if data is invalid, instead of returning default one.
This commit is contained in:
@@ -55,12 +55,12 @@ public abstract class AbstractBlockDeviceItem extends ModItem {
|
||||
|
||||
public ItemStack withData(final ItemStack stack, final BlockDeviceData data) {
|
||||
if (stack.isEmpty() || stack.getItem() != this) {
|
||||
return stack;
|
||||
return ItemStack.EMPTY;
|
||||
}
|
||||
|
||||
final ResourceLocation key = BlockDeviceDataRegistry.getKey(data);
|
||||
if (key == null) {
|
||||
return stack;
|
||||
return ItemStack.EMPTY;
|
||||
}
|
||||
|
||||
ItemStackUtils.getOrCreateModDataTag(stack).putString(DATA_TAG_NAME, key.toString());
|
||||
|
||||
@@ -53,12 +53,12 @@ public final class FlashMemoryWithExternalDataItem extends ModItem {
|
||||
|
||||
public ItemStack withFirmware(final ItemStack stack, final Firmware firmware) {
|
||||
if (stack.isEmpty() || stack.getItem() != this) {
|
||||
return stack;
|
||||
return ItemStack.EMPTY;
|
||||
}
|
||||
|
||||
final ResourceLocation key = FirmwareRegistry.getKey(firmware);
|
||||
if (key == null) {
|
||||
return stack;
|
||||
return ItemStack.EMPTY;
|
||||
}
|
||||
|
||||
ItemStackUtils.getOrCreateModDataTag(stack).putString(FIRMWARE_TAG_NAME, key.toString());
|
||||
|
||||
Reference in New Issue
Block a user